[tor-bugs] #22281 [Core Tor/Tor]: Prevent pattern of bugs caused by calling get_options() within options_validate() etc

[Tor Bug Tracker & Wiki]

#22281: Prevent pattern of bugs caused by calling get_options() within
options_validate() etc
------------------------------+--------------------------------
     Reporter:  nickm         |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 In #22252 and elsewhere, we hit a problem with calling a function that
 called get_options() -- both directly and via
 networkstatus_get_latest_consensus() -- before the options were fully
 assigned.

 We ought to do something to eliminate this pattern of bugs.

 One possibility might be to 'fill in' the new options before they're
 completely validated.  But we'd want to be able to roll back to the old
 options as needed if the new options _didn't_ validate.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22281>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online