[tor-bugs] #22044 [Applications/Tor Browser]: When I use the search box in the upper right it defaults to using youtube (on macOS)

[Tor Bug Tracker & Wiki]

#22044: When I use the search box in the upper right it defaults to using youtube
(on macOS)
-------------------------------------------------+-------------------------
 Reporter:  Dbryrtfbcbhgf                        |          Owner:  mcs
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff52-esr, tbb-7.0-must-alpha,        |  Actual Points:
  TorBrowserTeam201705R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by mcs):

 * status:  assigned => needs_review
 * keywords:  ff52-esr, tbb-7.0-must-alpha, TorBrowserTeam201705 =>
     ff52-esr, tbb-7.0-must-alpha, TorBrowserTeam201705R


Comment:

 The difference on OSX is due to
 https://bugzilla.mozilla.org/show_bug.cgi?id=1126722.
 But the real problem is that we are not setting the default search engine
 correctly: `browser.search.defaultenginename` needs to contain an URL.
 This is because the getter for `originalDefaultEngine`, which is defined
 in `browser/app/profile/000-tor-browser.js`, uses
 `nsIPrefBranch.getComplexValue()` to retrieve the pref value. The solution
 is to use a data: URL for the value (Mozilla
 defines`browser.search.defaultenginename.US` that way). Here is a patch:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug22044-01&id=a6a714a4541b3821267558c8c0a5ef725a91331a

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22044#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online