[tor-bugs] #22197 [Obfuscation]: Audit all of our Go code that uses `crypto/aes`.

[Tor Bug Tracker & Wiki]

#22197: Audit all of our Go code that uses `crypto/aes`.
-----------------------------+-----------------
     Reporter:  yawning      |      Owner:
         Type:  defect       |     Status:  new
     Priority:  Medium       |  Milestone:
    Component:  Obfuscation  |    Version:
     Severity:  Normal       |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |   Reviewer:
      Sponsor:               |
-----------------------------+-----------------
 The implementation is not constant time (and neither is the GHASH provided
 by `crypto/cipher`) without AES-NI/PCLMULQDQ or equivalent.  I do not
 believe that we use either in a situation where it matters, but we should
 double check to confirm this.  This affects any uses of the raw primitive,
 when wrapped in the various block cipher modes, and when used via TLS.

 Known uses:

  * obfs2
  * obfs3
  * scramblesuit
  * meek without a helper

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22197>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online