[tor-bugs] #21978 [Core Tor/Tor]: hs: Decouple adding and validating a service

[Tor Bug Tracker & Wiki]

#21978: hs: Decouple adding and validating a service
-----------------------------+------------------------------------
 Reporter:  dgoulet          |          Owner:  dgoulet
     Type:  enhancement      |         Status:  merge_ready
 Priority:  Medium           |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #21888           |         Points:  0.2
 Reviewer:  asn              |        Sponsor:  SponsorR-must
-----------------------------+------------------------------------
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:7 dgoulet]:
 > Replying to [comment:6 asn]:
 > > OK this last branch made the changes slightly clearer.
 > >
 > > Changes LGTM.
 > >
 > > One thing I did not understand is why the validation function is not
 called by `rend_service_check_dir_and_add()`, and instead we have to call
 both functions in a row.
 >
 > This changes heavily in prop224 refactoring (#21979) so it's not in that
 function... Would you prefer having it there and then modified in the
 refactoring?

 Nah, I think it's fine. It's just two occurrences for now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21978#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online