[tor-bugs] #22136 [Core Tor/Tor]: Make guards expire client connections

[Tor Bug Tracker & Wiki]

#22136: Make guards expire client connections
------------------------------+--------------------------------
     Reporter:  teor          |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:  0.3           |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 This is a follow-up to #21406.

 Now that channel_is_client() works, we should use it instead of
 or_circuit_t.is_first_hop.

 This will make circuit_expire_old_circuits_serverside() actually expire
 circuits correctly.

 The rest of the changes are logging or refactoring, the checks are either
 correct, or have no impact. (In connection_exit_begin_conn(), we will
 change an end reason from MISC to TORPROTOCOL.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22136>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online