[tor-bugs] #22110 [Core Tor/Tor]: Defining TOR_BUILD_TAG and tor_git_revision violates the version spec

[Tor Bug Tracker & Wiki]

#22110: Defining TOR_BUILD_TAG and tor_git_revision violates the version spec
------------------------------+--------------------------------
     Reporter:  teor          |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Minor         |   Keywords:  easy
Actual Points:                |  Parent ID:
       Points:  0.5           |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 When we removed the git revision in #2988, we allowed vendors to specify
 TOR_BUILD_TAG instead. But if we specify both TOR_BUILD_TAG and
 tor_git_revision, get_version() returns a string like this:
 {{{
 Tor 0.2.9.9 (TOR_BUILD_TAG) (git-tor_git_revision)
 }}}

 This violates the version spec, which only allows one set of brackets for
 EXTRA_INFO.
 https://gitweb.torproject.org/torspec.git/tree/version-spec.txt#n22

 So instead, we should use:
 {{{
 Tor 0.2.9.9 (TOR_BUILD_TAG,git-tor_git_revision)
 }}}

 (We can't use spaces in the EXTRA_INFO.)

 We should also write a unit test that checks that our own version passes
 the directory authority checks.

 This isn't serious, because the only programmatic interface that uses this
 is GETINFO version.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22110>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online