[tor-bugs] #21625 [Applications/Tor Browser]: Review networking code for Firefox 52

[Tor Bug Tracker & Wiki]

#21625: Review networking code for Firefox 52
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  mikeperry
     Type:  task                                 |         Status:
                                                 |  assigned
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Critical                             |     Resolution:
 Keywords:  TorBrowserTeam201703, ff52-esr,      |  Actual Points:
  tbb-7.0-must                                   |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by mikeperry):

 Ok, I'm done with the review. I conducted it a little different this time.
 I just did a 'git diff -U10 esr45 esr52' and focused primarily on the new
 lines, looking for various types of socket usage. (Things like the PR_
 calls, UDPSockets, SOCK_, etc). My review notes will be posted in the
 repo.

 I'm going to break the writeup down into categories on this ticket. First
 I'll list stuff that really needs to be patched. Then I'll list some stuff
 that we already patched that changed a bit (which may cause our patches to
 fail) that we should look at closely after patch application. Then I'll
 list stuff that it would be nice to have a second set of eyes confirm.

 We may also want someone to go over the android stuff again in more
 detail, as well.

 Will be posting the above mentioned sections one per comment here.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21625#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online