[tor-bugs] #20680 [Applications/Tor Browser]: Rebase Tor Browser patches to 52 ESR

[Tor Bug Tracker & Wiki]

#20680: Rebase Tor Browser patches to 52 ESR
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff52-esr, tbb-7.0-must,              |  Actual Points:
  TorBrowserTeam201703, tbb-7.0-must-nightly     |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor4
-------------------------------------------------+-------------------------

Comment (by gk):

 Let's start the review:

 `aacb4ae907f93c8ad07b4ac5141a181348a2530c`:
 1) There is "Bug 18884: Disable Loop extension" mentioned in the commit
 message but there is no sign of that one in the `.mozconfig files anymore
 2) f161c394e049a440637f06ba87dd6be6f73479bb should get merged keeping the
 bug 17858... in the commit message
 3) I cleaned up my extension signing patch a bit and moved the ICU support
 for Windows out; it should be in the `.mozconfig-mingw` directly (I have
 no clue which I thought that would be a good idea to add that piece to the
 extension signing patch, it is not); see my `bug_20680_icu_fixup` branch
 (https://gitweb.torproject.org/user/gk/tor-
 browser.git/log/?h=bug_20680_icu_fixup) for splitting up that patch

 `7a2928fb53ee51714a825cdcadc749274495a9ab`:
 1) Merge 2345b6f3aab2f26a3ce04cf482651bec0879e86b + mention bug in commit
 message
 2) Merge a3e507a2300e7bd8a9db14d2d2901cbee1c356b9 + mention bug in commit
 message
 3) Merge f99ab094e5daa9df1e541644fbc8afde745e3443 + mention bug in commit
 message
 4) `pref("gfx.xrender.enabled",false);` is already included in ESR52, no
 need to set it again

 `e0213fac01fb1fc9f0949490d652c6ae979d6bd4`: not needed anymore

 `046b74f2dfd53b29b3e4515c2533244b6924f69e`: good
 `0bd71cd9f84185c71d91784467293585d46e6367`: good
 `0eb5695b4a48b94ac98c076d4640fcfa64fdc832`: good
 `44755f47a01eb3623227df9124a93226d034b75e`: good
 `746cfdbfabce6ed31bbd58d46deaefa0ccabd1fd`: looks okay; I was wondering
 what to do with the remaining `COMPONENTS_SHIM_ACCESSED_BY_CONTENT`
 places. I guess keeping them is fine as this is Telemetry related which we
 disable anyway?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20680#comment:34>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online