[tor-bugs] #21643 [Core Tor/Tor]: Prop140: Extract, test, revise, and clean the diff code

[Tor Bug Tracker & Wiki]

#21643: Prop140: Extract, test, revise, and clean the diff code
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  2
  group-17                                       |
Parent ID:  #13339                               |         Points:  3
 Reviewer:  ahf                                  |        Sponsor:
                                                 |  Sponsor4
-------------------------------------------------+-------------------------
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Looks like all GL issues have been resolved. Looks good to me.

 I don't know if we have other code that could benefit from doing base64
 comparison without first decoding the base64 encoded buffer and then do a
 `memcmp()`, but if we have then it could be useful to lift that code out
 of the consdiff specific code.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21643#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online