[tor-bugs] #21334 [Core Tor/Tor]: prop224: Update prop224 HS desriptor generation code to produce the latest descriptor format

[Tor Bug Tracker & Wiki]

#21334: prop224: Update prop224 HS desriptor generation code to produce the latest
descriptor format
----------------------------------------------+----------------------------
 Reporter:  asn                               |          Owner:  asn
     Type:  enhancement                       |         Status:
                                              |  merge_ready
 Priority:  Very High                         |      Milestone:  Tor:
                                              |  0.3.1.x-final
Component:  Core Tor/Tor                      |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  tor-hs, prop224, review-group-16  |  Actual Points:
Parent ID:                                    |         Points:  3
 Reviewer:  nickm                             |        Sponsor:  SponsorR-
                                              |  must
----------------------------------------------+----------------------------

Comment (by asn):

 Replying to [comment:14 nickm]:
 > It looks like my comments were all addressed; please feel free to squash
 now.  If possible, please base the squash on the same starting point as
 "bug21334_v2", so that I can run "git diff bug21334_v2 bug21334_v3" and
 confirm that they are the same?  Once that's done and the tickets
 mentioned in the comments on gitlab are opened, I'm happy to merge this.
 >
 > Also, in the future, please consider using fixup! or squash! rather than
 TOSQUASH: "git-rebase" can handle those automatically.

 Hey Nick,

 I pushed `bug21334_v3` in my repo. The diff should be identical to my v2
 branch.

 I also opened #21693 for the double-base64 issue as requested, and I
 started working on a PoC for it. It's quite messy due to the nature of the
 change and the `char*->uint8_t` pointer madness, but I hope to have a
 draft ready at some point this week.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21334#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online