[tor-bugs] #21716 [Core Tor/Tor]: Avoid recursive call to routerlist_remove_old_routers via router_rebuild_store (was: duplicate log output)

[Tor Bug Tracker & Wiki]

#21716: Avoid recursive call to routerlist_remove_old_routers via
router_rebuild_store
--------------------------+------------------------------------
 Reporter:  anstein       |          Owner:
     Type:  defect        |         Status:  assigned
 Priority:  Medium        |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  easy intro    |  Actual Points:
Parent ID:                |         Points:  0.5
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  new => assigned
 * component:  Applications/Orbot => Core Tor/Tor
 * keywords:   => easy intro
 * points:   => 0.5
 * milestone:   => Tor: 0.3.2.x-final
 * owner:  n8fr8 =>


Comment:

 This is not a duplicate logging bug, and it's in tor, not orbot.

 It is due to a recursive call to routerlist_remove_old_routers via
 router_rebuild_store.

 Still, we should fix it eventually, because it's confusing, and recursive
 calls lead to subtle bugs and complex call graphs.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21716#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online