[tor-bugs] #21367 [Metrics/Atlas]: mark platform string red (or in some other obvious way) if recommended_version field is not true

[Tor Bug Tracker & Wiki]

#21367: mark platform string red (or in some other obvious way) if
recommended_version field is not true
---------------------------+------------------------------
 Reporter:  cypherpunks    |          Owner:  irl
     Type:  enhancement    |         Status:  needs_review
 Priority:  Medium         |      Milestone:
Component:  Metrics/Atlas  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+------------------------------

Comment (by cypherpunks):

 Coloring the software version red is redundant as there is already a
 bright red icon in the flags. Also the grammar of the tooltip could be
 improved (see the inline patch for my suggestion).

 {{{
 diff --git a/js/models/relay.js b/js/models/relay.js
 index 2a4fe17..f4ea7c6 100644
 --- a/js/models/relay.js
 +++ b/js/models/relay.js
 @@ -56,7 +56,7 @@ define([
                      output.push([flag,"cloud_download_"+size[0], "This
 relay is more useful for building general-purpose exit circuits than for
 relay circuits."]);
                  }
                  if (flag == "Not Recommended") {
 -                    output.push([flag,"not_recommended_"+size[0], "This
 relay is running a not recommended software version."]);
 +                    output.push([flag,"not_recommended_"+size[0], "This
 relay is running a software version that is not recommended by the
 directory authorities."]);
                  }
              });
              return output;
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21367#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online