[tor-bugs] #21585 [Core Tor/Tor]: Check code that uses consensus membership to find clients

[Tor Bug Tracker & Wiki]

#21585: Check code that uses consensus membership to find clients
------------------------------+--------------------------------
     Reporter:  teor          |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.1.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:  1             |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 In #21406, we identify clients by checking peer authentication
 information, as CREATE_FAST has been phased out.

 Most code that needs to know if the other end of a connection is a client
 uses membership in the consensus, but this is unreliable, as relays drop
 out of the consensus.

 So we should check code that uses node_t to identify clients, and switch
 it over to using this flag instead.

 This might mean creating an accessor function that takes an
 or_connection_t and returns whether the channel is a client.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21585>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online