[tor-bugs] #19699 [Core Tor/Tor]: Remove almost all functionality from Tor's test-network.sh

[Tor Bug Tracker & Wiki]

#19699: Remove almost all functionality from Tor's test-network.sh
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  029-proposed,                        |  Actual Points:
  tor-03-unspecified-201612                      |
Parent ID:                                       |         Points:  0.3
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorS-can
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  new => needs_review
 * points:  0.1 => 0.3


Comment:

 Please see my branch bug19699.

 If CHUTNEY_PATH is set, and chutney's tools/test-network.sh exists, tor's
 src/test/test-network.sh calls it using "$@" to preserve arguments with
 spaces.

 Otherwise, tor's src/test/test-network.sh parses the arguments, and calls
 chutney's tools/test-network.sh using the resulting CHUTNEY_PATH. (Parsing
 the arguments breaks any arguments that contain spaces, because it's not
 possible to save shell arguments in a portable way.)

 I don't think we'll restore the "upgrade chutney" reminder. It's annoying.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19699#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online