[tor-bugs] #1667 [Core Tor/Tor]: Give a more appropriate "I'm not an HTTP proxy" message when we get an HTTP request on the control port

[Tor Bug Tracker & Wiki]

#1667: Give a more appropriate "I'm not an HTTP proxy" message when we get an HTTP
request on the control port
-----------------------------------------+---------------------------------
 Reporter:  nickm                        |          Owner:  nickm
     Type:  enhancement                  |         Status:  needs_review
 Priority:  Very Low                     |      Milestone:  Tor:
                                         |  0.3.2.x-final
Component:  Core Tor/Tor                 |        Version:
 Severity:  Normal                       |     Resolution:
 Keywords:  tor-client, review-group-19  |  Actual Points:
Parent ID:                               |         Points:  small
 Reviewer:                               |        Sponsor:
-----------------------------------------+---------------------------------

Comment (by dgoulet):

 The fix looks good but tbh I would have put that pile of html in a static
 const char above the function or something. Else, it increase the size of
 this function and kind of clobbers the indentation. No strong opinion,
 just esthetic.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1667#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online