[tor-bugs] #22726 [Core Tor/Tor]: prop224: Ignore unparseable v3 introduction points

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Jun 27 13:46:26 UTC 2017


#22726: prop224: Ignore unparseable v3 introduction points
----------------------------------------------+----------------------------
 Reporter:  dgoulet                           |          Owner:  dgoulet
     Type:  defect                            |         Status:
                                              |  needs_revision
 Priority:  Medium                            |      Milestone:  Tor:
                                              |  0.3.2.x-final
Component:  Core Tor/Tor                      |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  tor-hs, prop224, review-group-19  |  Actual Points:
Parent ID:  #21888                            |         Points:
 Reviewer:  nickm, asn                        |        Sponsor:  SponsorR-
                                              |  must
----------------------------------------------+----------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Code LGTM.

 Only nitpick: `decode_intro_points()` is `STATIC` but not unittested.

 Marking `needs_revision` just for this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22726#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list