[tor-bugs] #20119 [Core Tor/Tor]: Fails to create the pid file when an enclosing directory is missing

Tue Jun 27 01:24:26 UTC 2017

#20119: Fails to create the pid file when an enclosing directory is missing
----------------------------------+----------------------------------
 Reporter:  yurivict271           |          Owner:
     Type:  defect                |         Status:  new
 Priority:  Medium                |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor          |        Version:  Tor: 0.2.8.7
 Severity:  Normal                |     Resolution:
 Keywords:  triaged-out-20170308  |  Actual Points:
Parent ID:                        |         Points:  .5
 Reviewer:                        |        Sponsor:
----------------------------------+----------------------------------

Comment (by arma):

 This one is safe to treat orthogonally to the mess in #22731, since the
 write_pidfile() function in options_act() happens after the
 finish_daemon() call.

 Shouldn't we be using check_private_dir() for the place where we're going
 to put our PidFile? And then we could pass it the CPD_CREATE flag?

 Then if write_pidfile() fails, we should error out.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20119#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online