[tor-bugs] #22154 [Metrics/metrics-lib]: Remove code that was deprecated in the 1.x series

[Tor Bug Tracker & Wiki]

#22154: Remove code that was deprecated in the 1.x series
---------------------------------+-----------------------------------
 Reporter:  karsten              |          Owner:  iwakeh
     Type:  enhancement          |         Status:  needs_review
 Priority:  Medium               |      Milestone:  metrics-lib 2.0.0
Component:  Metrics/metrics-lib  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+-----------------------------------
Changes (by iwakeh):

 * status:  accepted => needs_review
 * cc: iwakeh (added)


Comment:

 This task needs a four hands/four eyes approach;  there are so many
 changes which seem to cause 'code-blindness' after a while.

 A [https://gitweb.torproject.org/user/iwakeh/metrics-lib.git/?h=task-22154
 first branch here] has three commits:
 * one removing all deprecation warnings.
 * a second that makes tests and benchmark compile
 * a third that makes all tests except one pass
 (testDirectorySignaturesLinesTwoAlgorithms in
 RelayNetworkStatusVoteImplTest fails)

 Please review and change accordingly; maybe this needs another
 coding/review alteration.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22154#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online