[tor-bugs] #22690 [Core Tor/Tor]: SR: Authorities can add a reveal to their own vote, but expect a commit in all votes

[Tor Bug Tracker & Wiki]

#22690: SR: Authorities can add a reveal to their own vote, but expect a commit in
all votes
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:
     Type:  defect        |         Status:  needs_information
 Priority:  Medium        |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-sr        |  Actual Points:
Parent ID:                |         Points:  2
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by dgoulet):

 Replying to [comment:3 teor]:
 > Replying to [comment:2 dgoulet]:
 > > This is possible with a bad clock on the authority side which makes
 the relay thinks that it's in the REVEAL phase but it is in fact in the
 COMMIT phase.
 > >
 > > A bit weird though that you get that on chutney because all relays
 have the same clock! The logs here will definitely help out.
 >
 > chutney does some weird things with TestingV3AuthVotingStartOffset that
 might cause this issue. Occasionally one authority starts before the
 offset, and another starts after it, and their consensuses get out of
 sync.
 >
 > But this is really weird: it is an authority rejecting its own vote, so
 it has to have the same clock, right?

 I don't think so. The warning simply says that it received the
 `234887728412ECD247629DD98884444735F1A7AA` commit value with a reveal
 which was seen in the `234887728412ECD247629DD98884444735F1A7AA` vote.

 That log warning should *not* have been emitted by
 `234887728412ECD247629DD98884444735F1A7AA` else we have another problem!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22690#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online