[tor-bugs] #4019 [Core Tor/Tor]: Tor warns about public SocksPort addresses twice on startup
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Jun 22 01:11:54 UTC 2017
#4019: Tor warns about public SocksPort addresses twice on startup
-----------------------------------------------+---------------------------
Reporter: rransom | Owner: isis
Type: defect | Status:
| needs_review
Priority: Low | Milestone: Tor:
| 0.3.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-client, easy, review-group-18 | Actual Points:
Parent ID: | Points: 0.5
Reviewer: | Sponsor:
-----------------------------------------------+---------------------------
Changes (by isis):
* status: assigned => needs_review
Comment:
Okay, there's a patch in my `bug4091`
[https://github.com/isislovecruft/tor/tree/bug4091 branch]. While I was
at it, I also changed the function signature of
`warn_nonlocal_client_ports()` to make an argument `const` because it's
only ever read from.
The patch is basically a one-line fix that says "only respect the value of
the `CL_PORT_WARN_NONLOCAL` flag if `parse_ports()` wasn't called with
`validate_only==1`".
At first, I tried doing a different thing with setting a bit-field on each
`port_cfg_t` in `warn_nonlocal_client_ports()` (which is called by
`parse_port_config()`, which is then called by `parse_ports()` in two
different places), but since `parse_port_config()` sets up the smartlist
it just loses the marker that we had already warned and still warns twice.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4019#comment:33>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list