[tor-bugs] #22311 [Core Tor/Tor]: authdir_mode_any_nonhidserv() is an obsolete concept

[Tor Bug Tracker & Wiki]

#22311: authdir_mode_any_nonhidserv() is an obsolete concept
-------------------------------------------+-------------------------------
 Reporter:  arma                           |          Owner:
     Type:  defect                         |         Status:  merge_ready
 Priority:  Medium                         |      Milestone:  Tor:
                                           |  0.3.2.x-final
Component:  Core Tor/Tor                   |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  easy, tor-hs, review-group-18  |  Actual Points:
Parent ID:                                 |         Points:
 Reviewer:  arma                           |        Sponsor:
-------------------------------------------+-------------------------------
Changes (by nickm):

 * status:  needs_review => merge_ready


Comment:

 Thanks!  I've pulled this into my public repository as `bug22311`.  Here
 are the additional changes I suggest, which I've made on that branch:

  * I've made a fix to use authdir_mode_v3() instead of looking at
 V3AuthoritativeDir directly.
  * Since we no longer call authdir_mode_handles_descs() with purpose==-1,
 I am calling that behavior a bug.

 I also think that we _shouldn't_ take
 99c49cae9f8a354660a53dc2744cd0cc14c2e5b6 ("Remove
 authdir_mode_tests_reachability()") -- at some point in the future, we are
 likely to severely change how reachability testing works, especially on
 the bridge authorities.

 If this still looks okay, I'll rebase and squash and merge.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22311#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online