[tor-bugs] #22670 [Core Tor/Tor]: Clean up warning behavior of decompression code in connection_dir_client_reached_eof()

[Tor Bug Tracker & Wiki]

#22670: Clean up warning behavior of decompression code in
connection_dir_client_reached_eof()
------------------------------+--------------------------------
     Reporter:  nickm         |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.1.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:  #22502
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 There are several goofy things about the code that handles decompression
 in the above function.

 First, when it decides to try two decompression methods, it logs failures
 from either one, even though it's only a big problem when they both fail.

 Second, it treats a mismatched content-encoding as "info" when it should
 probably be "protocol_warn".

 Third, it should be in its own function.

 Fourth, the second call to warn_disallowed_anonymous_compression should
 probably only happen when we are about to call tor_uncompress() the second
 time.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22670>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online