[tor-bugs] #22343 [Applications/Tor Browser]: Save as... in the context menu results in using the catch-all circuit

[Tor Bug Tracker & Wiki]

#22343: Save as... in the context menu results in using the catch-all circuit
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  arthuredelstein
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tbb-linkability, ff52-esr,           |  Actual Points:
  tbb-7.0-must, TorBrowserTeam201706,            |
  tbb-7.0-issues, tbb-regression                 |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:
     tbb-linkability, ff52-esr, tbb-7.0-must, TorBrowserTeam201706R,
     tbb-7.0-issues, tbb-regression
     =>
     tbb-linkability, ff52-esr, tbb-7.0-must, TorBrowserTeam201706,
     tbb-7.0-issues, tbb-regression


Comment:

 Replying to [comment:9 arthuredelstein]:
 > Sorry for these errors. I think I have fixed this problem and made some
 other improvements. Here's a new version for review, rebased on top of the
 latest tor-browser 7.5 branch:
 >
 > ​https://github.com/arthuredelstein/tor-browser/commit/22343+1

 This breaks the `Save Image As...` option. Currently, that one is at least
 working even though the catch-all circuit is getting used. But with your
 patch I get
 {{{
 Full message: TypeError: aInitiatingDocument is null
 Full stack: continueSave at chrome://global/content/contentAreaUtils.js:467:1
 internalSave/<@chrome://global/content/contentAreaUtils.js:446:7
 Handler.prototype.process at resource://gre/modules/Promise.jsm ->
 resource://gre/modules/Promise-backend.js:932:23
 this.PromiseWalker.walkerLoop at resource://gre/modules/Promise.jsm ->
 resource://gre/modules/Promise-backend.js:813:7
 this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm
 -> resource://gre/modules/Promise-backend.js:747:11
 }}}
 . I guess it might be worth addressing the catch-all-circuit-issue for the
 image saving part while we are at it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22343#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online