[tor-bugs] #22635 [Internal Services/Service - jenkins]: Run tor's make test-stem in Jenkins

[Tor Bug Tracker & Wiki]

#22635: Run tor's make test-stem in Jenkins
-------------------------------------------------+------------------------
 Reporter:  catalyst                             |          Owner:  weasel
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Internal Services/Service - jenkins  |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:                                       |  Actual Points:
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+------------------------

Comment (by catalyst):

 I think you're right that there are environmental dependencies for those
 issues, but I think they're not uncommon ones.  I think to make this
 reproduce the observed failures, we would have to make sure there isn't a
 system tor binary installed in the Jenkins environment that runs this
 test.

 As I recall, the issues in #22301 depended on both the lack of a tor
 binary in the default PATH and running `make test-stem` in the tor source
 tree (instead of running `run_tests.py` in the stem source tree).  This is
 not an unusual combination, especially for a (possibly new) developer who
 has no reason to install a system tor.  (Note at least 3 developers
 independently experienced those bugs while attempting to follow the
 guidelines in `CodingStandards.md`.)

 Now that I think about it more, it's also useful to make sure that the
 stem tests don't unintentionally run the system tor (thereby producing
 invalid or misleading results).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22635#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online