[tor-bugs] #22618 [Applications/Tor Browser]: Downloading pdf file via file:/// is stalling if the external helper dialog is enabled

[Tor Bug Tracker & Wiki]

#22618: Downloading pdf file via file:/// is stalling if the external helper dialog
is enabled
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-7.0-issues, tbb-regression,      |  Actual Points:
  tbb-e10s                                       |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:5 mcs]:
 > I missed the fact that it had to be a local file (sorry!)
 > The cause is likely similar to that of #22471; my guess without looking
 at the code or debugging this problem is that the file: URL handler does
 not support the Suspend() / Resume() mechanism we added to work around
 #21766 and related problems. It seems like we will need to use a different
 technique to solve all of the problems, e.g., we could implement our
 download warning dialog the same way Mozilla implements their download-
 related prompts. Their prompts are asynchronous (which means the download
 proceeds while the user thinks about how to respond) but somehow the final
 download is blocked until the user finishes interacting with the dialog
 window. Maybe we can use Suspend() when it will work (i.e. for HTTP-based
 downloads) and skip the Suspend() in other cases.

 FWIW: I am all for getting rid of our extra dialog if we can afford it.
 But the underlying bug
 (https://bugzilla.mozilla.org/show_bug.cgi?id=440892), which was the
 reason for creating this workaround, is still not fixed. But given the
 problems we have with it we might want to think about getting Mozilla into
 the boat for solving this problem once and for all. I guess we can discuss
 this a bit on Monday during the meeting.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22618#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online