[tor-bugs] #21999 [Applications/Tor Browser]: The "request English language web pages"-prompt is not working in 7.0a3

[Tor Bug Tracker & Wiki]

#21999: The "request English language web pages"-prompt is not working in 7.0a3
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-7.0-must,    |  Actual Points:
  TorBrowserTeam201706R, tbb-7.0-issues, tbb-    |
  regression                                     |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):

 * status:  needs_revision => needs_review


Comment:

 Makes sense to me. Here's a different patch that I think preserves the
 behavior from before. One problem is that with e10s, the
 nsIWebProgressListener no longer delays the request. But "http-on-modify-
 request" observers correctly delays the request until their observe()
 function returns, so I am using one of those instead.

 The only drawback I see with this approach is that sometimes Firefox makes
 a background http request (such as checking for updates) and I'm not sure
 whether or not we want to show the prompt when that happens, and what the
 criteria should be for ignoring such requests.

 https://github.com/arthuredelstein/torbutton/commit/21999+2

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21999#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online