[tor-bugs] #22343 [Applications/Tor Browser]: Save as... in the context menu results in using the catch-all circuit

[Tor Bug Tracker & Wiki]

#22343: Save as... in the context menu results in using the catch-all circuit
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  arthuredelstein
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tbb-linkability, ff52-esr,           |  Actual Points:
  tbb-7.0-must, TorBrowserTeam201706             |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  tbb-linkability, ff52-esr, tbb-7.0-must, TorBrowserTeam201706R
     => tbb-linkability, ff52-esr, tbb-7.0-must, TorBrowserTeam201706
 * status:  needs_review => needs_revision


Comment:

 Loading torproject.org and doing a right-click and choosing "Save Page
 As..." gives me a ton of errors like:
 {{{
 [06-07 13:02:38] Torbutton NOTE: tor domain isolator error:
 channel.loadInfo is null
 loadInfo is null for channel
 https://www.torproject.org/images/military.jpg
 Handler function threw an exception: TypeError: channel.loadInfo is null
 Stack:
 NetworkMonitor.prototype._createNetworkEvent at resource://gre/modules/commonjs/toolkit/loader.js
 -> resource://devtools/shared/webconsole/network-monitor.js:1077:9
 NetworkMonitor.prototype._onRequestHeader at resource://gre/modules/commonjs/toolkit/loader.js
 -> resource://devtools/shared/webconsole/network-monitor.js:1154:5
 NetworkMonitor.prototype.observeActivity<@resource://gre/modules/commonjs/toolkit/loader.js
 -> resource://devtools/shared/webconsole/network-monitor.js:1014:7
 exports.makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js
 -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:101:14
 Line: 1077, column: 9
 }}}
 and it does not download anything (while default 7.0 at least downloads
 the website) I built a custom build with the patch in comment:5 applied on
 top. But that was the only difference to our usual nightly builds.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22343#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online