[tor-bugs] #22490 [Core Tor/Tor]: Stop using GeoIP country after buf has gone out of scope

[Tor Bug Tracker & Wiki]

#22490: Stop using GeoIP country after buf has gone out of scope
------------------------------+--------------------------------
     Reporter:  teor          |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.1.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  memory-safety
Actual Points:                |  Parent ID:
       Points:  0.2           |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 In geoip_parse_entry() (IPv6 case), we find `country` in `buf`, let `buf`
 go out of scope, then pass `country` to geoip_add_entry().

 Let's stop doing that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22490>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online