[tor-bugs] #22279 [Metrics/metrics-lib]: simplify and avoid repetition in ParserHelper methods

[Tor Bug Tracker & Wiki]

#22279: simplify and avoid repetition in ParserHelper methods
---------------------------------+-----------------------------------
 Reporter:  iwakeh               |          Owner:  karsten
     Type:  enhancement          |         Status:  reopened
 Priority:  Medium               |      Milestone:  metrics-lib 1.8.0
Component:  Metrics/metrics-lib  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+-----------------------------------
Changes (by karsten):

 * status:  closed => reopened
 * resolution:  implemented =>


Comment:

 Looks like we overlooked the case when a descriptor does not contain a
 line, e.g., `dirreq-v3-reqs`.  In this case,
 `ExtraInfoDescriptorImpl#dirreqV3Reqs` will stay `null`, and
 `ParseHelper#convertCommaSeparatedKeyIntegerValueList()` will not get a
 validated string from us but `null`.  Please find
 [https://gitweb.torproject.org/user/karsten/metrics-
 lib.git/commit/?h=task-22279-3&id=823fa496ce2b4f32f791fe7fd1859e67af068d3a
 this commit in my task-22279-3 branch] with a test and a fix.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22279#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online