[tor-bugs] #22311 [Core Tor/Tor]: authdir_mode_any_nonhidserv() is an obsolete concept

[Tor Bug Tracker & Wiki]

#22311: authdir_mode_any_nonhidserv() is an obsolete concept
--------------------------+------------------------------------
 Reporter:  arma          |          Owner:
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  easy, tor-hs  |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  arma          |        Sponsor:
--------------------------+------------------------------------

Comment (by arma):

 Hi huyvq! Thanks for the patches.

 Are you comfortable using git? If so, the best thing to do here would be
 to separate these into a series of commits, where each commit resolves one
 of the functions that doesn't need to exist anymore. That way we don't
 have a bigger diff where we're removing several functions at once and
 replacing several functions at once and it's harder to audit.

 It's possible that none of these functions are interconnected, that is,
 you could remove them in any order. It's also possible that there are some
 orderings of removal that are cleaner to do and some that are messier.

 I've also been looking through authdir_mode_publishes_statuses(), which
 looks like it doesn't have to exist anymore and could just be replaced
 with a call to authdir_mode()? It looks like there's an old comment in
 list_server_status_v1() about including v2 dir auths, which is not
 accurate anymore -- in fact, I just opened #22473 so we can get rid of
 that whole function, but that's not this ticket. :)

 And the same with authdir_mode_tests_reachability() -- now that all types
 of auths test reachability, I don't think we need a separate wrapper
 function.

 Tackling one function per commit will make auditing the commits much
 easier, and also it is the right sort of best practice for development. :)

 (If you don't want to deal with this, that's fine too, let us know and
 we'll try to refactor things into separate commits.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22311#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online