[tor-bugs] #17639 [Core Tor/Tor]: provide an option to display the expiry date of a given ed25519 signing key

[Tor Bug Tracker & Wiki]

#17639: provide an option to display the expiry date of a given ed25519 signing key
------------------------------------------------+--------------------------
 Reporter:  cypherpunks                         |          Owner:  isis
     Type:  enhancement                         |         Status:
                                                |  needs_revision
 Priority:  High                                |      Milestone:  Tor:
                                                |  0.3.2.x-final
Component:  Core Tor/Tor                        |        Version:  Tor:
                                                |  0.2.7.2-alpha
 Severity:  Normal                              |     Resolution:
 Keywords:  tor-ed25519-proto, review-group-21  |  Actual Points:
Parent ID:                                      |         Points:  1
 Reviewer:  nickm                               |        Sponsor:
------------------------------------------------+--------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 This looks comparatively solid to me!  A few things to consider as
 possibilities, though maybe they're not needed:

  - Maybe this should printf() something to stdout, instead of using the
 log facility, and run at --quiet by default?
  - Maybe the output format should be machine-readable?
  - Maybe it should dump information about the installed authority auth key
 as well
  - I wonder what it should do about hidden service keys?
  - Technically speaking, keys don't expire: certificates do. The user
 needs to replace both of them, not just one.
  - The buffer in log_ed_key_expiration() can probably just be stack-
 allocated.
  - Documentation on the new option should go into the manpage

 Please fix whatever from above you agree with. :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17639#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online