[tor-bugs] #23024 [Applications/Tor Browser]: Flags to increase hardening on Windows

[Tor Bug Tracker & Wiki]

#23024: Flags to increase hardening on Windows
--------------------------------------+--------------------------
 Reporter:  arthuredelstein           |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:                            |  Actual Points:
Parent ID:  #21448                    |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by arthuredelstein):

 Here's my patch for review. I would suggest we adding it after we have
 transitioned to rbm builds:
 https://github.com/arthuredelstein/tor-browser/commit/23024

 I tried building TBB with `-fstack-protector-strong` on mingw-w64 but so
 far ran into
 [https://sourceforge.net/p/mingw-w64/discussion/723798/thread/de524c41/#e4f9
 errors]. However, a Windows Tor Browser built with this patch (using
 `-fstack-protector-all`) doesn't seem subjectively slower to me, so I
 would suggest trying this on the alpha, at least until we have a solution
 for `-fstack-protector-strong` on mingw-w64.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23024#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online