[tor-bugs] #22924 [Core Tor/Tor]: signed integer overflow in unit tests crashes hardened build on 32-bit trusty

[Tor Bug Tracker & Wiki]

#22924: signed integer overflow in unit tests crashes hardened build on 32-bit
trusty
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.9.1-alpha
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  new => needs_revision
 * version:   => Tor: 0.2.9.1-alpha


Comment:

 Replying to [comment:1 nickm]:
 > See my branch `bug22924` against master.  I haven't figured out when
 this bug was first introduced, though.

 It's been there since test_dir_download_status_random_backoff() was
 introduced in commit 1553512 in tor-0.2.9.1-alpha, but we didn't find it
 until #17750, because the pre-#17750 unit tests used limited ranges.

 I tested the patch on i386 and x86_64 macOS, and it passes on both.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22924#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online