[tor-bugs] #22906 [Core Tor/Tor]: We might not want to commit Cargo.lock files
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Jul 12 23:26:10 UTC 2017
#22906: We might not want to commit Cargo.lock files
------------------------------+-----------------------------
Reporter: isis | Owner:
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Core Tor/Tor | Version:
Severity: Normal | Keywords: rust, tor-build
Actual Points: | Parent ID:
Points: 1 | Reviewer:
Sponsor: SponsorZ |
------------------------------+-----------------------------
In #22905, I discussed a problem that is partially the result of
committing `src/rust/Cargo.lock`.
> [Including `Cargo.lock` files] is possibly a good idea, because we're
specifying the hash we expect. It might be a bad idea, because it
specifies the registry for packages, which I'm pretty sure will mean
"offline" builds would never work. In addition, it also conflicts with the
dependency specification in `src/rust/tor_util/Cargo.toml` […]
That is, I'm pretty sure that no matter what we do on #22830, "offline"
builds are going to be broken because of including this lockfile. We
should figure out what the benefits of having it are, and if we can live
without them.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22906>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list