[tor-bugs] #21999 [Applications/Tor Browser]: The "request English language web pages"-prompt is not working in 7.0a3

[Tor Bug Tracker & Wiki]

#21999: The "request English language web pages"-prompt is not working in 7.0a3
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-7.0-must,    |  Actual Points:
  tbb-7.0-issues, tbb-regression,                |
  TorBrowserTeam201707R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):

 * keywords:
     ff52-esr, tbb-e10s, tbb-7.0-must, tbb-7.0-issues, tbb-regression,
     TorBrowserTeam201707
     =>
     ff52-esr, tbb-e10s, tbb-7.0-must, tbb-7.0-issues, tbb-regression,
     TorBrowserTeam201707R
 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:13 gk]:

 Thanks for the review and testing. Here is a revised branch, with the same
 patch revised to trigger the prompt only when a request is launched from a
 content "load context". I tested this new version with update requests and
 various about: pages and the prompt was not triggered.

 I also noticed that some homepage URLs were not being properly detected by
 function `torbutton_is_homepage_url(aURI)`. So I added a second patch to
 this new branch to try to take care of that problem.

 https://github.com/arthuredelstein/torbutton/commits/21999+3

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21999#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online