[tor-bugs] #22804 [Core Tor/Tor]: Refactor circuit_send_next_onionskin() to be less horribly large

[Tor Bug Tracker & Wiki]

#22804: Refactor circuit_send_next_onionskin() to be less horribly large
-----------------------------+------------------------------------
 Reporter:  nickm            |          Owner:
     Type:  defect           |         Status:  needs_review
 Priority:  Medium           |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  refactor tor-hs  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:  SponsorR
-----------------------------+------------------------------------

Comment (by arma):

 Your branch looks good, aside from the easter egg that you fixed:
 {{{
 -    log_warn(LD_BUG, "Unhandled purpose %d with a chosen exit; "
 +    log_warn(LD_BUG, "Unhandled purpose % dwith a chosen exit; "
 }}}

 I have taken your branch, rebased it to make it so your easter egg never
 happened, and added two more commits that I hope are helpful. It is now
 called {{{onionskin_refactor}}} still.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22804#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online