[tor-bugs] #22801 [Core Tor/Tor]: Warnings from isnan, isinfinite, signbit on mingw

[Tor Bug Tracker & Wiki]

#22801: Warnings from isnan, isinfinite, signbit on mingw
-------------------------+-------------------------------------------------
     Reporter:  nickm    |      Owner:
         Type:  defect   |     Status:  new
     Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
    Component:  Core     |    Version:
  Tor/Tor                |   Keywords:  028-backport 029-backport
     Severity:  Normal   |  030-backport 031-backport
Actual Points:           |  Parent ID:
       Points:           |   Reviewer:
      Sponsor:           |
-------------------------+-------------------------------------------------
 We're seeing these on jenkins.  They're somewhat annoying.  I have a fix.
 Making this ticket for tracking purposes.

 {{{
 11:32:49 In file included from src/common/util.c:44:0:
 11:32:49 src/common/util.c: In function 'clamp_double_to_int64':
 11:32:49 src/common/util.c:5602:13: error: conversion to 'float' from
 'double' may alter its value [-Werror=float-conversion]
 11:32:49    if (isnan(number)) {
 11:32:49              ^
 11:32:49 src/common/util.c:5620:16: error: conversion to 'float' from
 'double' may alter its value [-Werror=float-conversion]
 11:32:49    if (isfinite(number) && exponent <= 63) {
 11:32:49                 ^
 11:32:49 src/common/util.c:5625:18: error: conversion to 'float' from
 'double' may alter its value [-Werror=float-conversion]
 11:32:49    return signbit(number) ? INT64_MIN : INT64_MAX;
 11:32:49                   ^
 11:32:50 cc1: all warnings being treated as errors
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22801>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online