[tor-bugs] #22789 [Core Tor/Tor]: Tor 0.3.1.4-alpha crash on OpenBSD-current

[Tor Bug Tracker & Wiki]

#22789: Tor 0.3.1.4-alpha crash on OpenBSD-current
----------------------------------------------+----------------------------
 Reporter:  fredzupy                          |          Owner:
     Type:  defect                            |         Status:  new
 Priority:  High                              |      Milestone:  Tor:
                                              |  0.3.1.x-final
Component:  Core Tor/Tor                      |        Version:  Tor:
                                              |  0.3.1.4-alpha
 Severity:  Major                             |     Resolution:
 Keywords:  tor crash inet_pton ???-backport  |  Actual Points:
Parent ID:                                    |         Points:
 Reviewer:                                    |        Sponsor:
----------------------------------------------+----------------------------
Changes (by cypherpunks):

 * keywords:  tor crash inet_pton ???-backport openbsd c99 => tor crash
     inet_pton ???-backport


Comment:

 > I don't know if it's relevant but on OpenBSD, if the strtol() is too
 complicated to manage, there is strtonum() alternative which is meant to
 be simpler
 > is an OpenBSD extension

 OpenBSD's strtol not so complicated with compare to glibc's variant. Just
 some edge case you can to filter by simple check. "0x" syntax disallowed
 generally by tor_inet_pton so no more additional side effects.

 This bug affect all OpenBSD users, easy to target exit relays (by any
 client) and clients (by sites, etc)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22789#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online