[tor-bugs] #21324 [Applications/Tor Browser]: Don't update NoScript button every 24 minutes

[Tor Bug Tracker & Wiki]

#21324: Don't update NoScript button every 24 minutes
------------------------------------------+---------------------------
     Reporter:  gk                        |      Owner:  tbb-team
         Type:  enhancement               |     Status:  new
     Priority:  Medium                    |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Normal                    |   Keywords:  tbb-torbutton
Actual Points:                            |  Parent ID:
       Points:                            |   Reviewer:
      Sponsor:                            |
------------------------------------------+---------------------------
 Every 24 minutes we update the NoScript button according to the messages
 in my terminal looking like
 {{{
 Torbutton INFO: Updated NoScript status for security settings
 }}}
 This is done by calling `torbutton_update_noscript_button();`. The call is
 triggered by
 {{{
 if (data.startsWith("noscript.")) {
   torbutton_update_noscript_button();
 }
 }}}
 in our preference observer. It turns out there is a timer update happening
 every 24 minutes which gets saved in `noscript.subscription.lastCheck`.
 This is harmless for us as there are no subscription URLs available but
 nevertheless excessive.

 This got first mentioned in our blog: https://blog.torproject.org/blog
 /tor-browser-70a1-released#comment-232575

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21324>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online