[tor-bugs] #20862 [Core Tor/Tor]: Unittest fail on master: FAIL src/test/test_options.c:662: expected log to contain "Could not resolve local Address "

[Tor Bug Tracker & Wiki]

#20862: Unittest fail on master: FAIL src/test/test_options.c:662: expected log to
contain "Could not resolve local Address "
--------------------------+------------------------------------
 Reporter:  asn           |          Owner:  nickm
     Type:  defect        |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  .1
Parent ID:                |         Points:  0.2
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 Hello,

 I'm not near a NE regional train right now, so I can't really test it with
 a real DNS hijacker.

 That said, the fix looks good to me and tests pass fine on a normal
 network, so this is most probably an improvement!

 FWIW, should we leave this XXX in? It's more of a general comment than
 something we should address:
 {{{+  // XXXX But it _can_ exist, if you're DNS-hijacked.}}}

 Turning this to `merge_ready` thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20862#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online