[tor-bugs] #21119 [Core Tor/Trunnel]: Deprecate and replace type_getarray_val()

[Tor Bug Tracker & Wiki]

#21119: Deprecate and replace type_getarray_val()
----------------------------------+-------------------
     Reporter:  nickm             |      Owner:  nickm
         Type:  enhancement       |     Status:  new
     Priority:  Medium            |  Milestone:
    Component:  Core Tor/Trunnel  |    Version:
     Severity:  Normal            |   Keywords:
Actual Points:                    |  Parent ID:
       Points:                    |   Reviewer:
      Sponsor:                    |
----------------------------------+-------------------
 In the first version of the introduce1 branch, the type_getarray_val()
 accessor was used erroneously in a way that could have resulted in a
 buffer overflow.

 That bodes ill for its usability.  And since Trunnel is supposed to make
 it hard for us to make mistakes, we should consider fixing this.

 Brainstorming replacement ideas:

    * type_copyinto_val(object, input, input_len);
    * type_copyfrom_val(object, target, target_len);
    * type_getarray_checked(object, array, need_len);

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21119>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online