[tor-bugs] #20569 [Core Tor/Tor]: hs: Use AES256 prop224 descriptors

[Tor Bug Tracker & Wiki]

#20569: hs: Use AES256 prop224 descriptors
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, prop224, TorCoreTeam201612,  |  Actual Points:
  review-group-14                                |
Parent ID:                                       |         Points:  0.1
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorR-must
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Looks good.  Two tweaks:
    * AES256-CTR doesn't use a 256-bit IV.  Only the key is 256 bit.
    * Maybe instead of using CIPHER256_KEY_LEN all over hs_descriptor.c, it
 would be a good idea to have a HS_DESC_ENC_KEY_LEN or something?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20569#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online