[tor-bugs] #20957 [Applications/Tor Browser]: Get DieHarder working with Tor Browser

[Tor Bug Tracker & Wiki]

#20957: Get DieHarder working with Tor Browser
--------------------------------------+--------------------------------
 Reporter:  arthuredelstein           |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-hardened              |  Actual Points:
Parent ID:  #20955                    |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------------
Changes (by gk):

 * status:  new => needs_revision


Comment:

 Replying to [comment:8 emeryberger]:
 > When we conducted our studies - and when Arthur tested the patch - I
 replaced jemalloc with DieHarder.

 Did you do that like Arthur did? And if so, shouldn't you use
 `ac_add_options --enable-replace-malloc` in your .mozconfig to have it
 working properly (see: https://glandium.org/blog/?p=2848 and just to echo
 tom's concern)?

 Arthur: apart from that this patch needs revision. For one: my shell is
 complaining about `//`. Secondly, I think the bundle step is not the right
 one to build the library in. I think we should move that to `gitian-
 utils.yml`. Thirdly, one thing to test occurred to me: in the past we had
 issues with exporting an env variable in our start script and our
 automatic updates (see: #13359). We should make sure the `LD_PRELOAD`
 approach is still working in this scenario.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20957#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online