[tor-bugs] #21407 [Core Tor/Tor]: Make the usecreatefast default 0 in tor to match the consensus

[Tor Bug Tracker & Wiki]

#21407: Make the usecreatefast default 0 in tor to match the consensus
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:
     Type:  defect        |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.4.23
 Severity:  Normal        |     Resolution:
 Keywords:  security      |  Actual Points:
Parent ID:                |         Points:  1
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 I think this patch looks good, because:
 * if clients don't have a (directory guard or fallback or authority) onion
 key, they use TLS and CREATE_FAST
   * (the non-directory guard code makes sure we have an onion key before
 we connect)
 * if clients have an onion key, they default to using it, or the consensus
 parameter, or the torrc option

 Although, I just realised that if clients don't have a consensus, they
 won't believe any onion keys. So does this change have any effect at all?

 In either case, let's merge it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21407#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online