[tor-bugs] #21390 [Applications/Tor Browser]: keypress events are not getting spoofed

[Tor Bug Tracker & Wiki]

#21390: keypress events are not getting spoofed
--------------------------------------+---------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  closed
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Major                     |     Resolution:  not a bug
 Keywords:  tbb-fingerprinting        |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+---------------------------
Changes (by gk):

 * status:  reopened => closed
 * resolution:   => not a bug


Comment:

 Okay, this is not a bug. It turns out I mixed up `charCode` and `keyCode`
 values. While we spoof the latter the former are merely ASCII values of
 the key that got pressed. By coincidence both give back `63` for `?` on a
 with a german layout without spoofing. Our patch fixes that for the
 `keyCode` case leacing the `charCode` case untouched as it does not vary
 with a different keyboard layout.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21390#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online