[tor-bugs] #24754 [Core Tor/Tor]: Remove unnecessary heap allocations in Rust protover implementation.
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Dec 28 08:30:43 UTC 2017
#24754: Remove unnecessary heap allocations in Rust protover implementation.
------------------------------+--------------------
Reporter: frewsxcv | Owner: (none)
Type: enhancement | Status: new
Priority: Medium | Milestone:
Component: Core Tor/Tor | Version:
Severity: Minor | Keywords:
Actual Points: | Parent ID:
Points: | Reviewer:
Sponsor: |
------------------------------+--------------------
https://github.com/frewsxcv/tor/compare/frewsxcv-protover-heap?expand=1
This is my first Tor patch! 🎉
I was working towards
https://trac.torproject.org/projects/tor/ticket/24030 and noticed we do
some unnecessary heap allocations via `collect`.
Even though this is a small change I'm mostly opening to see what the
review/merge process is like. Also curious if small patches like this
should be folded into larger patches as separate commits, or if it's okay
to open individual tickets for them. If there's anything I'm doing wrong,
let me know – I've done virtually no open source work outside of GitHub
and am new to this Trac-based workflow.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24754>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list