[tor-bugs] #24197 [Applications/Tor Browser]: Building Windows 64 firefox with the sandbox enabled fails

[Tor Bug Tracker & Wiki]

#24197: Building Windows 64 firefox with the sandbox enabled fails
--------------------------------------+--------------------------
 Reporter:  boklm                     |          Owner:  tbb-team
     Type:  task                      |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-rbm                   |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by boklm):

 It looks like this patch from chromium is fixing the build issue we have
 in `security/sandbox/chromium/base/containers/hash_tables.h`:
 https://chromium.googlesource.com/chromium/src/+/411d3f7a3a18335713a46d9022ce25e018a19e47%5E%21/

 I attached it as `bug24197.patch` after removing from the patch the
 changes to the files that are not included in firefox.

 However, we now have a different build error:
 {{{
 /var/tmp/dist/mingw-w64/helpers/x86_64-w64-mingw32-g++ -std=gnu++11
 -mwindows -o Wow64_64.o -c   -DNDEBUG=1 -DTRIMMED=1 -DUNICODE -D_UNICODE
 -DNS_NO_XPCOM -D_CRT_RAND_S
 -DCHROMIUM_SANDBOX_BUILD -I/var/tmp/build/firefox-
 dca73c105071/security/sandbox -I/var/tmp/build/firefox-dca73c105071/obj-
 mingw/security/sandbox -I/var/tmp/build/firefox
 -dca73c105071/security/sandbox/chromium-shim -I/var/tmp/build/firefox-
 dca73c105071/security/sandbox/chromium -I/var/tmp/build/firefox-
 dca73c105071/nsprpub -I/var/tmp/bui
 ld/firefox-dca73c105071/obj-mingw/dist/include  -I/var/tmp/build/firefox-
 dca73c105071/obj-mingw/dist/include/nspr -I/var/tmp/build/firefox-
 dca73c105071/obj-mingw/dist/in
 clude/nss         -DMOZILLA_CLIENT -include /var/tmp/build/firefox-
 dca73c105071/obj-mingw/mozilla-config.h -MD -MP -MF .deps/Wow64_64.o.pp
 -Wall -Wc++11-compat -Wempty-
 body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-
 compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-
 offsetof -Wc++14-compat -Wno-
 error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error
 =array-bounds -Wno-format -fno-lifetime-dse -fno-exceptions -fno-strict-
 aliasing -mms-bitfields -f
 no-rtti -fno-exceptions -fno-math-errno -pipe  -g -O -fomit-frame-pointer
 /var/tmp/build/firefox-
 dca73c105071/security/sandbox/chromium/sandbox/win/src/Wow64_64.cc
 /var/tmp/build/firefox-
 dca73c105071/security/sandbox/chromium/sandbox/win/src/Wow64_64.cc:7:35:
 fatal error: sandbox/win/src/wow64.h: No such file or directory
 compilation terminated.
 make[5]: *** [Wow64_64.o] Error 1
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24197#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online