[tor-bugs] #16016 [Core Tor/Tor]: extrainfo_insert(): Bug: No entry found in extrainfo map.
Tor Bug Tracker & Wiki
blackhole at torproject.org
Sun Dec 24 09:43:50 UTC 2017
#16016: extrainfo_insert(): Bug: No entry found in extrainfo map.
-------------------------------------------------+-------------------------
Reporter: arma | Owner: (none)
Type: defect | Status: new
Priority: Medium | Milestone: Tor:
| unspecified
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-relay extrainfo warning | Actual Points:
annoying |
Parent ID: | Points: medium
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by teor):
This might be related to commit a21381a in 0.2.0.3-alpha, where we
disabled the desc_by_eid_map check in routerlist_assert_ok(). If we fix
this bug, we should re-enable it with a non-fatal assert.
{{{
/* XXXX
*
* Hoo boy. We need to fix this one, and the fix is a bit tricky,
so
* commenting this out is just a band-aid.
*
* The problem is that, although well-behaved router descriptors
* should never have the same value for their extra_info_digest, it's
* possible for ill-behaved routers to claim whatever they like there.
*
* The real answer is to trash desc_by_eid_map and instead have
* something that indicates for a given extra-info digest we want,
* what its download status is. We'll do that as a part of routerlist
* refactoring once consensus directories are in. For now,
* this rep violation is probably harmless: an adversary can make us
* reset our retry count for an extrainfo, but that's not the end
* of the world. Changing the representation in 0.2.0.x would just
* destabilize the codebase.
if (!tor_digest_is_zero(r->cache_info.extra_info_digest)) {
signed_descriptor_t *sd3 =
sdmap_get(rl->desc_by_eid_map, r->cache_info.extra_info_digest);
tor_assert(sd3 == &(r->cache_info));
}
*/
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16016#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list