[tor-bugs] #24667 [Core Tor/Tor]: OOM needs to consider the DESTROY queued cells

[Tor Bug Tracker & Wiki]

#24667: OOM needs to consider the DESTROY queued cells
----------------------------------------+----------------------------------
 Reporter:  dgoulet                     |          Owner:  (none)
     Type:  defect                      |         Status:  new
 Priority:  Medium                      |      Milestone:  Tor:
                                        |  0.3.3.x-final
Component:  Core Tor/Tor                |        Version:
 Severity:  Normal                      |     Resolution:
 Keywords:  tor-cell, tor-circuit, oom  |  Actual Points:
Parent ID:                              |         Points:
 Reviewer:                              |        Sponsor:
----------------------------------------+----------------------------------

Comment (by arma):

 Replying to [comment:1 arma]:
 > So, silently dropping destroy cells seems really bad and like we should
 really try to avoid it.
 >
 > While we're at it, we might want to get rid of the "send a truncate cell
 toward the client, and then let the client actually destroy the circuit"
 design.

 Do we have a similar issue to the "dropping destroy cells" issue here,
 where we queue up some truncated cells, and then the oom killer kills them
 before they go out, and then we've essentially dropped those truncated
 cells? In theory this one isn't so bad, since the client should eventually
 try to close the circuit too. But it's another instance where the two
 sides can become unsynced because we are mixing data and control cells on
 the same level. And it would be (much closer to) resolved by opting to get
 rid of the truncated/destroy/destroyed dance.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24667#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online