[tor-bugs] #24423 [Core Tor/Tor]: Fix STACK warnings in Tor

[Tor Bug Tracker & Wiki]

#24423: Fix STACK warnings in Tor
-----------------------------+------------------------------------
 Reporter:  nickm            |          Owner:  nickm
     Type:  defect           |         Status:  needs_revision
 Priority:  Medium           |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  review-group-27  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  catalyst         |        Sponsor:
-----------------------------+------------------------------------
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 The one_more_stack_fix changes probably aren't necessary on master.  I
 think STACK wouldn't complain about the `tt_assert(ch)` calls because they
 don't come after dereferences of `ch`.  The redundant check in the cleanup
 of `test_channel_flushmux()` on 0.3.2 probably should still be deleted if
 we would like to make 0.3.2 STACK-clean.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24423#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online